Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/identify: Assist in peer discovery based on reported listen addresses from other peers #2232

Merged
merged 7 commits into from
Oct 13, 2021

Conversation

thomaseizinger
Copy link
Contributor

Resolves #2216.

@thomaseizinger thomaseizinger force-pushed the identify-discovery branch 2 times, most recently from a3c44af to 052d1f0 Compare September 14, 2021 12:53
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross posting review here as well:

#2216 (comment)

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments. Overall I think this is a good idea.

protocols/identify/src/identify.rs Outdated Show resolved Hide resolved
protocols/identify/src/identify.rs Show resolved Hide resolved
@thomaseizinger thomaseizinger requested a review from mxinden October 7, 2021 04:33
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments. Missing a changelog entry. Other than that, this looks good to me.

protocols/identify/src/identify.rs Outdated Show resolved Hide resolved
protocols/identify/src/identify.rs Outdated Show resolved Hide resolved
Co-authored-by: Max Inden <mail@max-inden.de>
@thomaseizinger thomaseizinger changed the title Make Identify assist in peer discovery protocols/identify: Assist in peer discovery based on reported listen addresses from other peers Oct 13, 2021
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci!

protocols/identify/src/identify.rs Outdated Show resolved Hide resolved
protocols/identify/src/identify.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Identify should remember discovered peers and assist in peer discovery using addresses_of_peer
2 participants