-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protocols/identify: Assist in peer discovery based on reported listen addresses from other peers #2232
Conversation
a3c44af
to
052d1f0
Compare
052d1f0
to
51f71cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross posting review here as well:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments. Overall I think this is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments. Missing a changelog entry. Other than that, this looks good to me.
Co-authored-by: Max Inden <mail@max-inden.de>
Identify
assist in peer discoverybd2bc7a
to
cd1a81d
Compare
cd1a81d
to
96d3ca5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci!
Resolves #2216.