Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Use upstream multiaddr crate #2075

Merged
merged 3 commits into from
May 27, 2021
Merged

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented May 20, 2021

The history of the local multiaddr is that we just cloned the existing code in this repo for the sake of moving quickly.

Now that things have stabilized, we should backport changes to the upstream repository.

Fixes #758. Blocked on multiformats/rust-multiaddr#40.

@mxinden mxinden marked this pull request as ready for review May 26, 2021 15:53
@mxinden
Copy link
Member Author

mxinden commented May 27, 2021

@vmx do you have some spare cycles to give this a review?

Copy link
Contributor

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only checked the changes lines, so if there e.g. was a workspace internal package that wasn't updated properly i wouldn't catch it (though I guess the CI would).

@mxinden
Copy link
Member Author

mxinden commented May 27, 2021

I've only checked the changes lines, so if there e.g. was a workspace internal package that wasn't updated properly i wouldn't catch it (though I guess the CI would).

👍 thanks Volker!

@mxinden mxinden merged commit 28fe6ed into libp2p:master May 27, 2021
@mxinden mxinden mentioned this pull request May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to upstream multiaddr crate
2 participants