[swarm] MultiHandler: Respect inbound timeouts and upgrade versions. #1786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the
ProtocolsHandler::listen_protocol()
implementation of theMultiHandler
discards configured timeouts and upgrade protocol versions on the inner handlers. The former results in theMultiHandler
always having a default10
second timeout on inbound substream upgrades, regardless of the configuration on the inner handlers. The latter results in theMultiHandler
always using theupgrade::V1
negotiation protocol for inbound substream upgrades, which may not match what the inner handlers use for their corresponding outbound substreams - of course it should still be the same version used in all handlers, but it may not beV1
. So this PR does the following:MultiHandler
uses the maximum of all configured inbound timeouts on the inner handlers. Typically these are all the same but need not necessarily be.MultiHandler
uses theupgrade::Version
used by the inner handlers, unless they are not all the same, in which case a warning is logged andV1
used.