Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: Add ConnectionError to FromSwarm::ConnectionClosed #5484

Closed
dariusc93 opened this issue Jul 7, 2024 · 1 comment · Fixed by #5485
Closed

swarm: Add ConnectionError to FromSwarm::ConnectionClosed #5484

dariusc93 opened this issue Jul 7, 2024 · 1 comment · Fixed by #5485

Comments

@dariusc93
Copy link
Member

Description

Expose ConnectionError to FromSwarm::ConnectionClosed to allow behaviours to see the error that is related to the closure of the connection.

Motivation

When a connection close due to an error, the behaviour would not know or be able to act on that error, while swarm would be notified of the error.

Current Implementation

FromSwarm::ConnectionClosed does not report or provide ConnectionError.

Are you planning to do it yourself in a pull request ?

Yes
@dariusc93
Copy link
Member Author

See #5039

@dariusc93 dariusc93 mentioned this issue Jul 7, 2024
Merged
4 tasks
@dariusc93 dariusc93 changed the title swarm: report ConnectionError to FromSwarm::ConnectionClosed swarm: Add ConnectionError to FromSwarm::ConnectionClosed Jul 8, 2024
@mergify mergify bot closed this as completed in #5485 Jul 9, 2024
@mergify mergify bot closed this as completed in 02fa7c8 Jul 9, 2024
TimTinkers pushed a commit to unattended-backpack/rust-libp2p that referenced this issue Sep 14, 2024
@dariusc93 @TimTinkers
feat: Add ConnectionError to FromSwarm::ConnectionClosed
6abdfc7 
Resolves libp2p#5484.

Pull-Request: libp2p#5485.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add ConnectionError to FromSwarm::ConnectionClosed dariusc93/rust-libp2p
1 participant
@dariusc93