Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tcp): make TCP_NODELAY the default #4890

Closed
mxinden opened this issue Nov 18, 2023 · 1 comment · Fixed by #5469 or #5764
Closed

feat(tcp): make TCP_NODELAY the default #4890

mxinden opened this issue Nov 18, 2023 · 1 comment · Fixed by #5469 or #5764
Labels
decision-pending Marks issues where a decision is pending before we can move forward. difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted
Milestone
v0.54.0

Comments

@mxinden
Copy link
Member

mxinden commented Nov 18, 2023

Description

Make TCP_NODELAY the default. In other words, disable Nagle's algorithm.

Rational of Golang setting TCP_NODELAY as default: golang/go#57530

Motivation

Trading low latency over throughput, especially when sending small messages.

Already our defacto default, see various examples using it: https://github.com/search?q=repo%3Alibp2p%2Frust-libp2p%20nodelay&type=code

Current Implementation

TCP_NODELAY is not the default.

rust-libp2p/transports/tcp/src/lib.rs

Line 168 in a7d4cb3

nodelay: None,

Are you planning to do it yourself in a pull request ?

No
@mxinden mxinden added difficulty:easy help wanted getting-started Issues that can be tackled if you don't know the internals of libp2p very well decision-pending Marks issues where a decision is pending before we can move forward. labels Nov 18, 2023
@mxinden mxinden added this to the v0.54.0 milestone Nov 18, 2023
@shubhexists shubhexists mentioned this issue Nov 23, 2023
Closed
2 tasks
@jxs jxs mentioned this issue Jun 13, 2024
Merged
2 tasks
@mergify mergify bot closed this as completed in #5469 Jun 13, 2024
mergify bot pushed a commit that referenced this issue Jun 13, 2024
@jxs
feat(tcp): make TCP_NODELAY the default
a35e269 
Superseeds #4916.
Fixes: #4890.

Pull-Request: #5469.
@romac
Copy link

romac commented Sep 12, 2024

I believe the linked PR did not actually address this issue, cf. #5469 (comment)

TimTinkers pushed a commit to unattended-backpack/rust-libp2p that referenced this issue Sep 14, 2024
@jxs @TimTinkers
feat(tcp): make TCP_NODELAY the default
4acbd80 
Superseeds libp2p#4916.
Fixes: libp2p#4890.

Pull-Request: libp2p#5469.
@elenaf9 elenaf9 reopened this Dec 24, 2024
@elenaf9 elenaf9 mentioned this issue Dec 25, 2024
Merged
4 tasks
@mergify mergify bot closed this as completed in #5764 Jan 10, 2025
@mergify mergify bot closed this as completed in ba8da16 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decision-pending Marks issues where a decision is pending before we can move forward. difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted
Projects
None yet
Milestone
v0.54.0
3 participants
@romac @mxinden @elenaf9