Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove async from DNS builder methods #4832

Closed
thomaseizinger opened this issue Nov 9, 2023 · 0 comments · Fixed by #5468
Closed

Remove async from DNS builder methods #4832

thomaseizinger opened this issue Nov 9, 2023 · 0 comments · Fixed by #5468
Milestone
v0.54.0

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Nov 9, 2023 •
edited
Loading

See #4808 (comment)_.
@thomaseizinger thomaseizinger added this to the v0.54.0 milestone Nov 9, 2023
@dariusc93 dariusc93 mentioned this issue Jun 13, 2024
Merged
4 tasks
@mergify mergify bot closed this as completed in #5468 Jun 18, 2024
@mergify mergify bot closed this as completed in 0b1733d Jun 18, 2024
TimTinkers pushed a commit to unattended-backpack/rust-libp2p that referenced this issue Sep 14, 2024
@dariusc93 @TimTinkers
refactor: remove redundant async signature
061f1c5 
Resolves libp2p#4832

Pull-Request: libp2p#5468.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.54.0
Development

Successfully merging a pull request may close this issue.

refactor: remove redundant async signature dariusc93/rust-libp2p
1 participant
@thomaseizinger