Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dcutr::Event::DirectConnectionUpgradeSucceeded should include the ConnectionId #4519

Closed
Tracked by #4523
thomaseizinger opened this issue Sep 19, 2023 · 2 comments · Fixed by #4558
Closed
Tracked by #4523

dcutr::Event::DirectConnectionUpgradeSucceeded should include the ConnectionId #4519

thomaseizinger opened this issue Sep 19, 2023 · 2 comments · Fixed by #4558

Comments

@thomaseizinger
Copy link
Contributor

This would be useful to know, which of our connections is the direct connection to this peer.
@thomaseizinger thomaseizinger mentioned this issue Sep 20, 2023
Closed
@dariusc93
Copy link
Member

Should the same be said for Event::DirectConnectionUpgradeFailed too?

@thomaseizinger
Copy link
Contributor Author

Should the same be said for Event::DirectConnectionUpgradeFailed too?

I guess so? We do certainly have a ConnectionId for that dial attempt so we could report it. I guess that makes sense for consistency's sake.

@dariusc93 dariusc93 mentioned this issue Sep 26, 2023
Merged
4 tasks
@mergify mergify bot closed this as completed in #4558 Oct 20, 2023
mergify bot pushed a commit that referenced this issue Oct 20, 2023
@dariusc93
feat(dcutr): add ConnectionId to upgrade success/failed events
3c00ae8 
Resolves #4519.

Pull-Request: #4558.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dcutr): add ConnectionId to upgrade success/failed events dariusc93/rust-libp2p
2 participants
@dariusc93 @thomaseizinger