Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dcutr): remove direct handler #4013

Closed
mxinden opened this issue May 31, 2023 · 0 comments · Fixed by #4016
Closed

fix(dcutr): remove direct handler #4013

mxinden opened this issue May 31, 2023 · 0 comments · Fixed by #4016
Labels
difficulty:easy help wanted priority:nicetohave

Comments

@mxinden
Copy link
Member

mxinden commented May 31, 2023

Description

Remove libp2p_dcutr::handler::direct.

Motivation

The only reason why we have libp2p_dcutr::handler::direct::Handler is to emit an event once the direct connection is established. This has been needed, but with recent refactorings in libp2p-swarm one might as well just emit the event from the libp2p_dcutr::Behaviour right away.

See #3982 (comment) for details.

Are you planning to do it yourself in a pull request?

No
@mxinden mxinden mentioned this issue May 31, 2023
Merged
4 tasks
@tcoratger tcoratger mentioned this issue May 31, 2023
Merged
4 tasks
@mergify mergify bot closed this as completed in #4016 Jun 1, 2023
mergify bot pushed a commit that referenced this issue Jun 1, 2023
@tcoratger
refactor(dcutr): remove direct::Handler
87e863e 
With recent refactorings in `libp2p-swarm`, there is no more need for `handler::direct` at all.

Resolves #4013.

Pull-Request: #4016.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy help wanted priority:nicetohave
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(dcutr): remove direct::Handler tcoratger/rust-libp2p
1 participant
@mxinden