abstract-stream: should support undefined logger #2275
Labels
need/author-input
Needs input from the original author
need/triage
Needs initial labeling and prioritization
Comments
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Dec 1, 2023
Update dependencies and fix various breaking changes introduced by those dependency updates: - Change type of Conn to Duplex<Uint8Array | Uint8ArrayList> - Pass a logger stub to yamux as it's now required. The logger stub should not be necessary once these are fixed: - ChainSafe/js-libp2p-yamux#69 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#70 Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Dec 1, 2023
NOTE: The following issues must be addressed before this is merged: libp2p/interface is currently held at version 0.1.2: - Passing a logger to MuxerInit is now required (should be optional?): libp2p/js-libp2p#2275 @chainsafe/libp2p-yamux is currently held at version 5.0.4: - Passing a logger to yamux()({logger:...}) is now required (should be optional?): ChainSafe/js-libp2p-yamux#69 - The integration test for rpcstream fails with 6.x vs. 5.x: ChainSafe/js-libp2p-yamux#71 and https://github.com/aperturerobotics/starpc/actions/runs/7055030516/job/19204891175 See: #120 --- Update dependencies and fix various breaking changes introduced by those dependency updates: - Change type of Conn to Duplex<Uint8Array | Uint8ArrayList> - Pass a logger stub to yamux as it's now required. The logger stub should not be necessary once these are fixed: - ChainSafe/js-libp2p-yamux#69 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#70 Signed-off-by: Christian Stewart <christian@aperture.us>
|
When libp2p configures these components it passes a logging implementation in which is why it's not optional anywhere. Could you speak a bit more to your use case? Are you doing something different here? |
|
I'm using js-libp2p-yamux externally from libp2p and don't want to pass a logger. |
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Dec 11, 2023
NOTE: The following issues must be addressed before this is merged: libp2p/interface is currently held at version 0.1.2: - Passing a logger to MuxerInit is now required (should be optional?): libp2p/js-libp2p#2275 @chainsafe/libp2p-yamux is currently held at version 5.0.4: - Passing a logger to yamux()({logger:...}) is now required (should be optional?): ChainSafe/js-libp2p-yamux#69 - The integration test for rpcstream fails with 6.x vs. 5.x: ChainSafe/js-libp2p-yamux#71 and https://github.com/aperturerobotics/starpc/actions/runs/7055030516/job/19204891175 See: #120 --- Update dependencies and fix various breaking changes introduced by those dependency updates: - Change type of Conn to Duplex<Uint8Array | Uint8ArrayList> - Pass a logger stub to yamux as it's now required. The logger stub should not be necessary once these are fixed: - ChainSafe/js-libp2p-yamux#69 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#70 Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Dec 19, 2023
See: - #120 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#71 Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Jan 10, 2024
NOTE: The following issues must be addressed before this is merged: libp2p/interface is currently held at version 0.1.2: - Passing a logger to MuxerInit is now required (should be optional?): libp2p/js-libp2p#2275 @chainsafe/libp2p-yamux is currently held at version 5.0.4: - Passing a logger to yamux()({logger:...}) is now required (should be optional?): ChainSafe/js-libp2p-yamux#69 - The integration test for rpcstream fails with 6.x vs. 5.x: ChainSafe/js-libp2p-yamux#71 and https://github.com/aperturerobotics/starpc/actions/runs/7055030516/job/19204891175 See: #120 --- Update dependencies and fix various breaking changes introduced by those dependency updates: - Change type of Conn to Duplex<Uint8Array | Uint8ArrayList> - Pass a logger stub to yamux as it's now required. The logger stub should not be necessary once these are fixed: - ChainSafe/js-libp2p-yamux#69 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#70 Signed-off-by: Christian Stewart <christian@aperture.us>
|
I give up on this and will just pass a stub Log from now on. |
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Jan 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass a logger stub to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Jan 17, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass a logger stub to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Jan 17, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass a logger stub to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Feb 7, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass a logger stub to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Feb 7, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Feb 9, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this issue
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <christian@aperture.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Abstract stream currently requires a non-undefined logger:
js-libp2p/packages/utils/src/abstract-stream.ts
Line 29 in bca8d6e
js-libp2p/packages/utils/src/abstract-stream.ts
Line 94 in bca8d6e
js-libp2p/packages/utils/src/abstract-stream.ts
Line 196 in bca8d6e
In previous releases of js-libp2p-yamux we could pass an empty components object without a logger, but this is not possible anymore as Log is required for AbstractStream: ChainSafe/js-libp2p-yamux#69
Please make log an optional parameter for AbstractStreamInit, maybe using a no-op shim internally if necessary (when it's undefined), so that the construct for
yamux()()is backwards-compatible and doesn't need to have a Logger passed every time.The same is true for MuxerInit: it appears to now require a not-null Logger at construct time.
The text was updated successfully, but these errors were encountered: