feat: async await and upgrades Hapi to v18

[achingbrain]

BREAKING CHANGE: All api functions that took callbacks now return promises

Still uses pull-streams internally because if it ain't broke you shouldn't try to fix it.

[achingbrain]

Includes the changes from #7

[achingbrain]

Pending merging of roylines/node-epimetheus#63

[vasco-santos]

Thanks for the PR @achingbrain

All in all, it looks good. Left a minor question

[vasco-santos]

Why not doing async await here as well?

[achingbrain]

It didn't appear to be part of the public API and is only invoked in the context of a socket.io-pull-stream handler which is all callbacks.

[mkg20001]

Looks good, waiting for merge of upstream module

If this doesn't get merged in a timely manner, should we just use a fork instead?

[achingbrain]

@mkg20001 I don't know if that PR will ever get merged, it looks a bit like that module has been abandoned.

I've published a fork with the Hapi 18 PR as menoetius (keeping with the Greek mythology theme).

I'll remove it from this repo if the PR ever gets merged.

[mkg20001]

Ok, merging then

[mkg20001]

npm seems to hate me.

Is it because of missing 2fa?

[achingbrain]

I'm not sure - is it required for the package? Do you have it enabled?

Aegir will prompt you for an OTP automatically if it detects the challenge in the response.

[mkg20001]

Unsure and no
That's why I'm confused

[achingbrain]

I think you can check if you log in to the npm website: https://docs.npmjs.com/requiring-2fa-for-package-publishing-and-settings-modification

Also, you should enable 2FA 😉

[mkg20001]

I've enabled 2fa for my account and set it to authorization only.

Same error, no clue why.

Created a tarball using npm (in case any generated files are needed that aren't in the repo)

package.zip

@daviddias Could you try publishing this? (zip includes a tarball created by npm and a signature for that tarball)

Edit: I've contacted support about this, but it's weekend, so I'll have to wait until monday.

[jacobheun]

FYI I am looking into some issues with this. There are internal usages of crypto that were not migrated from callbacks to async/await with the latest version bumps causing crypto handshakes to stall and fail.