This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: dropped packed #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems that this test is weird: https://github.com/libp2p/interface-stream-muxer/blob/master/src/base-test.js#L99-L145 |
|
I don't even.... tableflip |
|
... but yay! Supposedly it's working! That's great news and thanks a lot for digging into it, I'm happy you found a solution. On the other side, none of the CI services are green in this PR ;) |
50 tasks
feab0c9 to
5677306
Compare
|
@victorbjelkholm there was a test in interface-stream-muxer that was incorrect. fixed now. CI will be all green in a sec. Can I get a PR approval ? |
victorb
reviewed
Jan 24, 2017
| @@ -11,7 +11,6 @@ const pump = require('pump') | |||
| function create (rawConn, isListener) { | |||
| const stream = toStream(rawConn) | |||
| // Let it flow, let it flooow | |||
There was a problem hiding this comment.
Should remove this comment as well
victorb
approved these changes
Jan 24, 2017
5677306 to
a7cfb8b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@victorbjelkholm after some long hours of debugging, we managed to find the issue.
multiplex from the listener side was opening the streams before the dialer had the time to mount the muxer and so, when it got to mount the muxer, some data events were already emitted because of the resume call.
This was super tough one to fix! Big thanks for @pgte for pairing with me debugging it.
//cc @dignifiedquire you will find this hilarious
//cc @haadcode @RichardLitt stream muxer is under way!