This repository was archived by the owner on Jul 21, 2023. It is now read-only.
Fix: send correct payload in ADD_PROVIDER RPC #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the go implementation of the DHT does reject ADD_PROVIDER messages where the peer ID in the payload does not match the remote peer id, so this fix should improve provides |
alanshaw
approved these changes
May 30, 2019
vasco-santos
approved these changes
May 30, 2019
|
Excellent catch, @dirkmc !! Are you adding a tiny interop test to ipfs/interop that checks js-ipfs providing to a go-ipfs network? |
|
That's a good idea, I will add a test once this is merged: ipfs/interop#36 |
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the payload for ADD_PROVIDER we were sending remote peers their own id instead of the local node's id. The tests still passed because on the receiving end we ignore the payload and just look at the connection to get the provider peer id.