Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Upgrade libp2p-crypto-secp256k1 + fix Secp256k1 tests #151

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jul 10, 2019

Upgrade libp2p-crypto-secp256k1 dependency and ensure that Secp256k1 supported is tested properly.

@aknuds1
Copy link
Contributor Author

aknuds1 commented Jul 10, 2019

@jacobheun @vasco-santos Here's a fix to ensure that Secp256k1 is supported through this library.

@aknuds1 aknuds1 force-pushed the bugfix/upgrade-secp256k1 branch 4 times, most recently from 6b3c6e8 to 3169913 Compare July 10, 2019 12:07
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Since this is just adding tests I'd like to merge this in after #131. I can take on rebasing and updated this to async/await, once that's done.

@aknuds1
Copy link
Contributor Author

aknuds1 commented Jul 10, 2019

Fantastic! Since this is just adding tests I'd like to merge this in after #131. I can take on rebasing and updated this to async/await, once that's done.

@jacobheun Looking forward to seeing the new async API :D

@jacobheun jacobheun force-pushed the bugfix/upgrade-secp256k1 branch from 7335cb8 to 0d24833 Compare July 10, 2019 22:13
@jacobheun
Copy link
Contributor

Rebased this with master and switched the tests over to async/await!

@jacobheun jacobheun merged commit 5500ac4 into libp2p:master Jul 10, 2019
@aknuds1 aknuds1 deleted the bugfix/upgrade-secp256k1 branch July 11, 2019 07:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants