Support wsl. #9
Support wsl. #9
Conversation
|
|
||
| impl IfWatcher { | ||
| /// Create a watcher | ||
| pub async fn new() -> Result<Self> { | ||
| Ok(Self(platform_impl::IfWatcher::new().await?)) | ||
| if std::env::var_os("WSL_DISTRO_NAME").is_none() { | ||
| Ok(Self::Platform(platform_impl::IfWatcher::new().await?)) |
There was a problem hiding this comment.
not sure where exactly this failed before, but does it make sense to try the fallback if this errored?
There was a problem hiding this comment.
this might lead to missing bug reports, so I'd prefer not to do it
|
|
||
| impl IfWatcher { | ||
| /// Create a watcher | ||
| pub async fn new() -> Result<Self> { | ||
| Ok(Self(platform_impl::IfWatcher::new().await?)) | ||
| if std::env::var_os("WSL_DISTRO_NAME").is_none() { |
There was a problem hiding this comment.
I got a feeling that there will be more weird linux situations where the event based stuff does not work. So I am not really opposed to just trying and using the fallback on error.
But since so far we know of only this case, I am also fine with checking for it.
Let's revisit it once this becomes a longer list.
| @@ -51,7 +51,7 @@ impl IfWatcher { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub fn iter(&self) -> impl Iterator<Item = &IpNet> { | |||
| pub fn iter(&self) -> Iter<'_, IpNet> { | |||
There was a problem hiding this comment.
because the fallback and platform_impl need to return the same iterator
There was a problem hiding this comment.
rust can't assume that it is the same iterator when using impl even if it is
|
FYI: not sure what the tests do, but they are green on the wsl branch, and red on master, on WSL2 |
Closes #8