Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Revert "add mutex for write/close" #73

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Revert "add mutex for write/close" #73

merged 1 commit into from
Feb 5, 2020

Conversation

Stebalien
Copy link
Member

Actually fixed in multiformats/go-multistream#50

This reverts commit f6ca84a.

@Stebalien Stebalien requested a review from vyzo February 4, 2020 18:24
vyzo
vyzo approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay for the right fix; hopefully it won't come back to bite us.

@Stebalien
Copy link
Member Author

Github needs a 🤞 reaction.

@Stebalien
Copy link
Member Author

My primary motivation for reverting this is that this currently prevents us from closing a stream that's blocked on writing.

@Stebalien Stebalien merged commit 2a43c4c into master Feb 5, 2020
@Stebalien Stebalien deleted the fix/revert-mutex branch February 5, 2020 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @vyzo