This repository has been archived by the owner on May 26, 2022. It is now read-only.
Update to go-reuseport 0.2.0 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer implicitly provided by go-reuseport's Dialer as it was removed.
Closed
1 task
Stebalien
approved these changes
Jan 4, 2019
| // Dials using reusport and then redials normally if that fails. | ||
| func reuseDial(ctx context.Context, laddr *net.TCPAddr, network, raddr string) (net.Conn, error) { | ||
| // Dials using reuseport and then redials normally if that fails. | ||
| // TODO(anacrolix): This shouldn't fail anymore: Remove fallback. |
There was a problem hiding this comment.
This is for when we can't pick a reasonable source port. For example, when:
- We're listening on two localhost addresses.
- We're dialing a non-localhost address.
In that case, we'll use the multiDialer (we have multiple source ports to choose from) but we'll end up picking none of them.
Really, we could probably just not call reuseDial in this case.
|
Merging this now to restore functionality. TODO:
Given that most users are still stuck with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-reuseportno longer provides aDialerthat implicitly appliesSetLinger(0). This restores expected functionality.