Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introspection support: implement host.IntrospectableHost and wire up the introspector #885

Closed
wants to merge 30 commits into from

Conversation

aarshkshah1992
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 commented Apr 14, 2020

For #775.

This PR introduces changes to the Runtime message and integrations tests for the Introspector for the introspection 2.0 protocol defined at libp2p/go-libp2p-core#142.

To try it out :

h1, err := New(ctx,
		Introspector(
			introspector.NewDefaultIntrospector(),
			introspector.WsServerWithConfig(&introspector.WsServerConfig{
				ListenAddrs: []string{iaddr},
			}),
		),
		BandwidthReporter(metrics.NewBandwidthCounter()),
	)

@aarshkshah1992 aarshkshah1992 requested a review from raulk April 14, 2020 12:22
@aarshkshah1992 aarshkshah1992 changed the base branch from master to feat/introspection April 14, 2020 12:23
@aarshkshah1992 aarshkshah1992 changed the title Host changes for the Introspection 2.0 protocol [WIP] Host changes for the Introspection 2.0 protocol Apr 14, 2020
@aarshkshah1992 aarshkshah1992 changed the base branch from feat/introspection to master April 17, 2020 06:47
@raulk raulk changed the title [WIP] Host changes for the Introspection 2.0 protocol introspection support: implement host.IntrospectableHost and wire up the introspector May 20, 2020
@raulk
Copy link
Member

raulk commented Jun 5, 2020

Closing this PR and opening a new one to describe the changeset more accurately.

@raulk
Copy link
Member

raulk commented Jun 5, 2020

Superseded by #964.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants