Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade protocol mux failure log to debug #443

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Oct 1, 2018

There is no real information conveyed (so it's really not INFO) and there is tons of it.

The more pertinent question is why I see so many of them -- probably because of prevalence of undialable addrs

@ghost ghost assigned vyzo Oct 1, 2018
@ghost ghost added the status/in-progress In progress label Oct 1, 2018
@vyzo vyzo requested a review from Stebalien October 1, 2018 07:38
@Stebalien
Copy link
Member

It could either be that the connection was killed or that the stream was reset. I'm not sure which.

@Stebalien
Copy link
Member

Actually, do you have time to look into why we're getting these and document that in an issue? It would be nice if we actually knew.

@vyzo
Copy link
Contributor Author

vyzo commented Oct 3, 2018

Sure, I can do some investigative work.

@vyzo
Copy link
Contributor Author

vyzo commented Oct 3, 2018

In the meantime, should we merge this? It's really spamming at INFO level.

@Stebalien Stebalien merged commit 27f502e into master Oct 5, 2018
@ghost ghost removed the status/in-progress In progress label Oct 5, 2018
@Stebalien
Copy link
Member

Yeah... fine. As long as we don't forget...

@Stebalien Stebalien deleted the fix/log-spam branch October 5, 2018 00:41
@vyzo
Copy link
Contributor Author

vyzo commented Oct 5, 2018

I'll open issue for the investigation, I don't have any good ideas yet.

@vyzo
Copy link
Contributor Author

vyzo commented Oct 5, 2018

Opened #447.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants