Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport/websocket): enable pulling http proxy from environment variables #3136

Closed
wants to merge 1 commit into from

Conversation

aschmahmann
Copy link
Collaborator

related to #286 it seems like there was an undocumented behavioral regression in libp2p/go-ws-transport@0ea4a8a whereby we no longer respected various standard environment variables related to HTTP(S) proxies for the websocket transport. This puts the behavior back.

@parkan could you try this out in singularity and report back if it's good enough for your use case?


A few notes/areas for comment:

  1. Any recommendations on testing to prevent regressions here? Importing a socks5 server library just for a test like this seems like overkill, but maybe folks have better ideas
  2. Any objections to using the environment variables rather than making it an option?
  3. Any recommendations on where to document this behavior? It seems like there's some documentation missing here that'd be nice (e.g. the environment variables go-libp2p users may want to set, even if they're from downstream libraries and we're not committed to them like for HTTP Proxies, go-log, etc.)

@MarcoPolo
Copy link
Collaborator

Close in favor of #3137

@MarcoPolo MarcoPolo closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants