feat(transport/websocket): enable pulling http proxy from environment variables #3136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #286 it seems like there was an undocumented behavioral regression in libp2p/go-ws-transport@0ea4a8a whereby we no longer respected various standard environment variables related to HTTP(S) proxies for the websocket transport. This puts the behavior back.
@parkan could you try this out in singularity and report back if it's good enough for your use case?
A few notes/areas for comment: