Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcmgr: Breaking change. Add OpenConnectionNoIP to interface #2806

Closed
wants to merge 1 commit into from

Conversation

MarcoPolo
Copy link
Collaborator

To merge before we make the next minor release.

This adds a OpenConnectionNoIP method to the interface for the resource manager. It's used by users who want a connection scope, but don't have an IP address to tie to the connection. I believe the only user is circuitv2 relays.

The reasons to prefer a new method over changing OpenConnectionIP to be circuitv2 aware is:

  • The caller should be explicit about not having an IP address.
  • The resource manager code should not be aware of circuitv2.

Verified

This commit was signed with the committer’s verified signature.
kadiwa4 Kalle Wachsmuth
@sukunrt
Copy link
Member

sukunrt commented May 22, 2024

Why make an exception for IP addresses vs Non IP addresses. Users who want to implement their custom behavior anyway need to wrap our implementation and do their custom stuff on top.

I think the better way is to remove the method OpenConnectionNoIP and let users who want custom limiting wrap OpenConnection and implement it themselves.

Similar comment here: #2805 (comment)

@MarcoPolo
Copy link
Collaborator Author

Lets move discussion to #2805 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants