Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

use the Resource Manager #249

Merged
merged 2 commits into from
Jan 18, 2022
Merged

use the Resource Manager #249

merged 2 commits into from
Jan 18, 2022

Conversation

marten-seemann
Copy link
Collaborator

@marten-seemann marten-seemann commented Dec 31, 2021 •
edited
Loading

This is without passing ReserveMemory functions to quic-go. We're just using it to open / accept connections and streams.

When reviewing, please pay attention to the hole punching logic.

@marten-seemann marten-seemann requested a review from vyzo December 31, 2021 09:45
@marten-seemann marten-seemann force-pushed the rcmgr branch 2 times, most recently from ecc97e2 to 3bdf846 Compare December 31, 2021 09:57
vyzo
vyzo reviewed Dec 31, 2021
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to hook the memory rsvp as well, but ok for now.

conn.go Outdated Show resolved Hide resolved
listener.go Outdated Show resolved Hide resolved
transport.go Show resolved Hide resolved
@marten-seemann marten-seemann mentioned this pull request Jan 1, 2022
Closed
69 tasks
@marten-seemann marten-seemann requested a review from vyzo January 1, 2022 11:06
vyzo
vyzo reviewed Jan 1, 2022
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to Done the scope on closure

@marten-seemann marten-seemann force-pushed the rcmgr branch 2 times, most recently from 5e8e177 to daa8e64 Compare January 4, 2022 13:20
marten-seemann
marten-seemann commented Jan 6, 2022
View reviewed changes
listener.go Outdated Show resolved Hide resolved
@marten-seemann marten-seemann force-pushed the rcmgr branch 4 times, most recently from d3f72ec to cfb93f4 Compare January 14, 2022 11:58
@marten-seemann marten-seemann force-pushed the rcmgr branch 10 times, most recently from 4013832 to 4509027 Compare January 18, 2022 07:08
@marten-seemann marten-seemann force-pushed the rcmgr branch 2 times, most recently from dfe3025 to 2933aa4 Compare January 18, 2022 07:15
@marten-seemann marten-seemann requested a review from vyzo January 18, 2022 07:23
@marten-seemann marten-seemann merged commit b7a53c7 into master Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @vyzo