This repository has been archived by the owner on May 26, 2022. It is now read-only.
export qlogs when the QLOGDIR env variable is set #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection ID used for logging is the destination connection ID chosen by the client, both for the server's and the client's log file. This allows us to easily correlate two log files, if we happen to have logs from both endpoints.
This also means that if a client manages to create two connections with the same destination connection ID in the same microsecond, we will only have the log of one of those connections. I think we can live with that.
Side note: I'll cut a new quic-go release after this PR is merged. I've made quite a few improvements of qlog after the last release.