Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timeout context for NewStream call #994

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Use timeout context for NewStream call #994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crawler/crawler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@

// SendRequest sends a peer a message and waits for its response
func (ms *messageSender) SendRequest(ctx context.Context, p peer.ID, pmes *pb.Message) (*pb.Message, error) {
s, err := ms.h.NewStream(ctx, p, ms.protocols...)
tctx, cancel := context.WithTimeout(ctx, ms.timeout)
defer cancel()

s, err := ms.h.NewStream(tctx, p, ms.protocols...)

Check warning on line 81 in crawler/crawler.go

View check run for this annotation

Codecov / codecov/patch

crawler/crawler.go#L78-L81 

Added lines #L78 - L81 were not covered by tests
if err != nil {
return nil, err
}
Expand All @@ -86,8 +89,6 @@
}

r := protoio.NewDelimitedReader(s, network.MessageSizeMax)
tctx, cancel := context.WithTimeout(ctx, ms.timeout)
defer cancel()
defer func() { _ = s.Close() }()

msg := new(pb.Message)
Expand Down