Make the Routing Table's latency tolerance configurable. #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
536626e to
fececcc
Compare
aarshkshah1992
suggested changes
Feb 18, 2020
| @@ -69,6 +71,13 @@ var Defaults = func(o *Options) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func RoutingTableLatencyTolerance(latency time.Duration) Option { | |||
There was a problem hiding this comment.
Could you add some documentation for this function ?
| @@ -99,7 +99,7 @@ func New(ctx context.Context, h host.Host, options ...opts.Option) (*IpfsDHT, er | |||
| if err := cfg.Apply(append([]opts.Option{opts.Defaults}, options...)...); err != nil { | |||
| return nil, err | |||
| } | |||
| dht := makeDHT(ctx, h, cfg.Datastore, cfg.Protocols, cfg.BucketSize) | |||
| dht := makeDHT(ctx, h, cfg.Datastore, cfg.Protocols, cfg.BucketSize, cfg.RoutingTable.LatencyTolerance) | |||
| dht.autoRefresh = cfg.RoutingTable.AutoRefresh | |||
There was a problem hiding this comment.
While you are on this, would you mind just passing the whole config object to makeDHT and reading in the values there ? IMO, what we have right now isn't really neat.
|
@vibhavp Thanks for the PR ! If you are interested in making more contributions to the DHT or libp2p in general, please feel free to ask for any kind of help on freenode IRC at #libp2p or post your comments on https://discuss.libp2p.io/. |
|
@aarshkshah1992 I've made the requested changes, could you take a look? |
aarshkshah1992
approved these changes
Feb 19, 2020
|
LGTM. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.