This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
introspection: rename package, rm ListenAddr() from interface. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee8012e to
7276de2
Compare
|
Gonna merge this into the feature branch, to make go.mod version management easier. |
|
@raulk LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introspectionpackage name is more intuitive.ListenAddrs()method shouldn't be part of this interface. An introspector is the thing that performs the introspection, which can be injected in an introspection server to serve the data over an endpoint -- the latter is where the listen addresses belong.