This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Support wildcard subscriptions + getter for known types #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
May 5, 2020
17 tasks
|
Superseded by #40. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface change at libp2p/go-libp2p-core#142.
We need this for the introspection work being done for libp2p/go-libp2p#775.
This will allow the introspection server to inform the client/Introspection UI about all events it will be receiving and about the types of the fields of these events so it can format them accordingly.
See https://github.com/libp2p/go-libp2p-core/blob/8fb76f42df5015dda050025a8b578f061967db02/introspection/pb/introspection.proto#L64.
This PR ALSO puts in a change to allow "wildcard" i.e. "catch-all" subscriptions.