This repository has been archived by the owner on May 26, 2022. It is now read-only.
use the new SecureTransport and SecureMuxer interfaces #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
437e7af to
5b24709
Compare
Stebalien
approved these changes
Sep 8, 2021
| if err != nil { | ||
| return nil, false, fmt.Errorf("failed to secure inbound connection: %s", err) | ||
| } | ||
| // ensure the correct peer connected to us | ||
| if sconn.RemotePeer() != p { |
There was a problem hiding this comment.
What about p != "" && p != sconn.RemotePeer()? Just slightly safer.
There was a problem hiding this comment.
Why? In case our secure transports mess up?
Should we make this an assertion then (i.e. a panic)?
There was a problem hiding this comment.
Yes. I'd log loudly and fail, but I wouldn't panic (would turn a bug into a DoS). Again, we should catch this at a higher layer as well, but this is something that's nice to check at all layers just in case we mess something up in one of them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.