Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on pygit2 that corresponds to the installed libgit2 #847

Closed
white-gecko opened this issue Dec 16, 2018 · 9 comments
Closed

Depend on pygit2 that corresponds to the installed libgit2 #847

white-gecko opened this issue Dec 16, 2018 · 9 comments
Labels

Comments

@white-gecko
Copy link
Contributor

Sorry this is not a bug report, but a request for help.

I have a project that depends on pygit2. In my requirements.txt I've specified the dependency as pygit2==0.27.2 because I have libgit2 in version 0.27.x on my system. On other systems different versions of libgit2 might be installed. How can I specify the dependency to match the locally installed version? (https://www.pygit2.org/install.html#version-numbers)

Is this even possible with pip or is this a task to be done with distutils and a setup.py?

How do other users of the pygit2 do it? Could this maybe be added to the README/Wiki?

@imbuedhope
Copy link
Contributor

imbuedhope commented Dec 19, 2018

Something like this, but in place of the OS condition, scan the filesystem for which version of the libgit2 .so file is present on the machine.

@white-gecko
Copy link
Contributor Author

Thank you very much, but this will not work on other platforms … this might be the next problem. On Stackoverflow somebody answered to build a "fat wheel" https://stackoverflow.com/questions/53781394/install-pygit2-with-pip-in-the-same-version-as-libgit2. Would it be possible for pygit2 to publish such fat wheels on pypi?

@jdavid
Copy link
Member

jdavid commented Dec 22, 2018

There's already issue #793 about manylinux wheels, help is appreciated.

@jdavid jdavid added the support label Dec 22, 2018
@balki
Copy link

balki commented Feb 6, 2019

+1 This issue makes pygit2 unusable. Any python package using pygit2, should either depend on 0.26 or 0.27. Which means it is not portable. For e.g. Ubuntu 18.04 packages 0.26 while Ubuntu18.10 does 0.27. I want to use pygit2 for this project https://gitlab.com/balki/git-log-edit project and it is blocked because I have no way to make it pip installable.

@jdavid
Copy link
Member

jdavid commented Feb 9, 2019

Have you tried https://pypi.org/project/venvgit2/ ?

@webknjaz
Copy link
Contributor

Hopefully, #869 will solve this issue

@webknjaz
Copy link
Contributor

@balki @imbuedhope @white-gecko #876 is another thing where help is needed if someone's up to doing some C coding...

@jdavid
Copy link
Member

jdavid commented Mar 19, 2019

0.28.0 released with manylinux wheels (work done by @webknjaz)

closing

@jdavid jdavid closed this as completed Mar 19, 2019
@webknjaz
Copy link
Contributor

@jdavid great, thanks!

white-gecko added a commit to AKSW/QuitStore that referenced this issue Apr 11, 2019
pygit2 has manylinux wheels now which do not depend on the locally
install libgit2 anymore
libgit2/pygit2#847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants