-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust GitStatusOptions to match structure of native libgit2 #1884
Conversation
This fixes a marshaling bug that causes a segmentation fault
Codecov Report
@@ Coverage Diff @@
## master #1884 +/- ##
=======================================
Coverage 84.60% 84.61%
=======================================
Files 231 231
Lines 9174 9175 +1
=======================================
+ Hits 7762 7763 +1
Misses 1412 1412
Continue to review full report at Codecov.
|
Can we get this merged soon? Turns out this is the reason every status query fails with the most recent dotnet runtime (5.0.7). Thanks! |
Hi @bording, I'm tagging you here, because you seem to be the member of libgit2 who most recently interacted with this repository. Quite a few people are affected by this issue here. Any chance you can release a new (preview) version after merging this PR? Thanks |
This change has been published as 0.27.0-preview-0100. |
Thank you so much, @bording. Now libgit2sharp is working again with the most recent dotnet runtime. Awesome! |
Includes a fix libgit2/libgit2sharp#1884 for `AccessViolationException` on .NET SDK 5.0.7.
This fixes a marshaling bug that causes a segmentation fault
This mismatch caused dotdevelop's git module to crash.
More about this can be found here:
dotdevelop#2