-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout branch looks to remote tracking branches as fallback #1820
Conversation
Too bad no one has reviewed this yet. The ceremony required to achieve this is somewhat annoying (see https://stackoverflow.com/a/23344700/1025555). |
Codecov Report
@@ Coverage Diff @@
## master #1820 +/- ##
==========================================
+ Coverage 84.60% 84.66% +0.05%
==========================================
Files 231 231
Lines 9174 9193 +19
==========================================
+ Hits 7762 7783 +21
+ Misses 1412 1410 -2
Continue to review full report at Codecov.
|
45ca139
to
f98274d
Compare
I agree. It's been more than a year now that I submitted this PR and I still haven't received feedback from any reviewer... This is rather rude. People such as myself use their own personal time to contribute to open-source projects and the least we expect is some kind of acknowledgement in a timely fashion (even if it's to say "sorry, don't have time to review right now"). If there had been no recent activity on this project or there were hundreds of open PRs, I might understand why I haven't received any feedback yet, but this isn't the case. I'd really like to know if resolving the issue is not a priority, the PR is badly implemented or whatnot... @bording, since you appear to have approved most of the recent PRs, please advise. |
Hey @louis-z, Sorry about the lack of response, I know how frustrating that can be! As you have noticed, I'm largely the only contributor/maintainer still paying any attention to the repo. For a variety of reasons, I've not really had the spare time to devote to this for a while, so the time I do have has been focused on pulling in changes that unblock being able to use the library at all on a given OS or version of the framework. For example, recent PRs that I have reviewed and merged have fixed crashes when running on .NET 5 or unblocking the use of single-file publishing.
Yes, and that is true of me as well. I'm not paid to work on LibGit2Sharp, so I also have to use personal time when working on things here, and as I mentioned above, I've not had much of that lately. All that being said, I'll try and take a look at this PR soon and let you know what changes might be needed before it can be merged. |
Thanks @bording. Sorry for the rant. I guess we're all in the same boat, huh? |
Thanks for the PR! I've pushed 0.27.0-preview-0175 to nuget.org, which includes these changes. |
Resolves #1564
When checking out a
<branch>
, do as what the git checkout command does: