Refactor and Clean Up WriterTest for PHP GEDCOM Library #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created by Sweep to resolve the following request by @curtisdelicata:
Continue chatting at https://sweep-chat-demo.vercel.app/c/bc77b4a0-e4bb-4351-942d-267f45329d1b.
Purpose
Improve the test suite for the Writer class in the PHP GEDCOM library by removing unnecessary comments, simplifying test methods, and ensuring consistent test coverage.
Description
This pull request focuses on cleaning up and streamlining the
WriterTest.php
file. The changes include:The refactoring maintains the existing test coverage while improving code readability and maintainability. Each test method now focuses on a specific scenario with minimal boilerplate code.
Summary
tests/WriterTest.php
Writer::convert()
method