Patch to ensure that deadlines with zero delay are never met

core/reactor.c

@@ -200,7 +200,7 @@ int _lf_do_step(void) {
         // at most once per logical time value. If the violation reaction triggers the
         // same reaction at the current time value, even if at a future superdense time,
         // then the reaction will be invoked and the violation reaction will not be invoked again.
-        if (reaction->deadline > 0LL) {
+        if (reaction->deadline >= 0LL) {
             // Get the current physical time.
             instant_t physical_time = lf_time_physical();
             // FIXME: These comments look outdated. We may need to update them.
@@ -210,7 +210,7 @@ int _lf_do_step(void) {
             // container deadlines are defined in the container.
             // They can have different deadlines, so we have to check both.
             // Handle the local deadline first.
-            if (physical_time > current_tag.time + reaction->deadline) {
+            if (reaction->deadline == 0 || physical_time > current_tag.time + reaction->deadline) {
                 LF_PRINT_LOG("Deadline violation. Invoking deadline handler.");
                 // Deadline violation has occurred.
                 violation = true;

core/reactor_common.c

@@ -1681,11 +1681,11 @@ void schedule_output_reactions(reaction_t* reaction, int worker) {
             }
         }
 #endif
-        if (downstream_to_execute_now->deadline > 0LL) {
+        if (downstream_to_execute_now->deadline >= 0LL) {
             // Get the current physical time.
             instant_t physical_time = lf_time_physical();
             // Check for deadline violation.
-            if (physical_time > current_tag.time + downstream_to_execute_now->deadline) {
+            if (downstream_to_execute_now->deadline == 0 || physical_time > current_tag.time + downstream_to_execute_now->deadline) {
                 // Deadline violation has occurred.
                 violation = true;
                 // Invoke the local handler, if there is one.

core/threaded/reactor_threaded.c

@@ -861,11 +861,11 @@ bool _lf_worker_handle_deadline_violation_for_reaction(int worker_number, reacti
     // at most once per logical time value. If the violation reaction triggers the
     // same reaction at the current time value, even if at a future superdense time,
     // then the reaction will be invoked and the violation reaction will not be invoked again.
-    if (reaction->deadline > 0LL) {
+    if (reaction->deadline >= 0LL) {
         // Get the current physical time.
         instant_t physical_time = lf_time_physical();
         // Check for deadline violation.
-        if (physical_time > current_tag.time + reaction->deadline) {
+        if (reaction->deadline == 0 || physical_time > current_tag.time + reaction->deadline) {
             // Deadline violation has occurred.
             violation_occurred = true;
             // Invoke the local handler, if there is one.

lingua-franca-ref.txt

@@ -1 +1 @@
-544168274369b9d3893695846171bd2ed43d4682
+25e67092a31bb30811a7907bc2b8644b9a2d2b43