-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SET
work with both token and non-token types
#66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also change the names to lower case, as suggested, leaving the old names, marked deprecated, for backward compatibility.
From the error message it seems like the lower case
|
a9a9923
to
567cd6a
Compare
567cd6a
to
58d8768
Compare
SET
SET
work with both token and non-token types
SET
work with both token and non-token typesSET
work with both token and non-token types
Update the `SET`, `tag` and `schedule` APIs and deprecate old ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for cleaning up the C API.
Superficially, should files like ctarget_schedule.h
be organized as ctarget/schedule.h
instead?
I've been critical of the move to a separate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too big for me to go through in detail right now, but it looks good. What is the plan for updating the tests? Ideally, they all pass unchanged (backward compatibility), but then we update them so that they serve as proper examples. We also need to update the website code and docs.
My plan is to update the tests after merging this PR and lf-lang/lingua-franca#1097. In regards to Marten's concern, I can do the renaming in a future PR. I think the most time-sensitive actions right now is to get the API out and to update the tests and the website |
Added a destructor variant of
SET
and changed the signature ofSET_ARRAY
.Refer to #65 for details.
The LF tests related to this change are added here: lf-lang/lingua-franca#1097
This PR makes
SET
work with both token type and non-token types.This PR also includes changes from #68 since that PR was merged into this PR before merging into main.