Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal Models #6

Merged
merged 20 commits into from
Mar 1, 2022
Merged

Modal Models #6

merged 20 commits into from
Mar 1, 2022

Conversation

a-sr
Copy link
Contributor

@a-sr a-sr commented Oct 20, 2021

@a-sr a-sr requested a review from lhstrh October 20, 2021 13:54
@a-sr a-sr mentioned this pull request Oct 20, 2021
Merged
11 tasks
a-sr added 13 commits October 20, 2021 18:50
@a-sr
modes: Added support for resetting state variables
0718169
@a-sr
Added handling for suspended events with micro steps
2416c66
@a-sr
modes: Memory of suspended evens will be freed at termination
4f5ead5
@a-sr
modes: Switched to using _lf_schedule_at_tag when for suspended events
79c7af7 
_lf_schedule applied minimal spacing and base delays
@a-sr
Merge branch 'main' into modal-models
4dc8f81
@a-sr
Merge remote-tracking branch 'origin/main' into modal-models
9372810
@a-sr
modes: Fix bug in defragmentation of suspended events list
9951906 
that caused seg fault
@a-sr
modes: Switched to a linked list structure to store suspended events
52ad31a
@a-sr
modes: Added experimental support for threaded execution for modes
9f133ca
@a-sr
modes: Improved allocation of array.
19a9f59 
Resolved compiler errors C2057 and C2466.
@a-sr
modes: Added explicit cast after malloc
e1d381e
@a-sr
Merge remote-tracking branch 'origin/main' into modal-models
e5b09f8
@a-sr
modes: Fixed bug in suspended events list and timer offset
f027918
@a-sr a-sr marked this pull request as ready for review February 8, 2022 17:38
@lhstrh lhstrh mentioned this pull request Feb 13, 2022
Merged
@edwardalee
Copy link
Contributor

Where are we with this modal-models PR? Can we merge?

lhstrh
lhstrh approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty solid to me, but I think that some things in reactor_common.c would be better split off into a separate modal.c. I'm OK with merging this now and doing a refactoring later.

@lhstrh lhstrh mentioned this pull request Mar 1, 2022
Closed
@edwardalee edwardalee merged commit d2d908b into main Mar 1, 2022
@edwardalee edwardalee deleted the modal-models branch March 1, 2022 23:56
@petervdonovan petervdonovan mentioned this pull request Jul 18, 2022
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-sr @edwardalee @lhstrh