Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress towards Python 3.11 support #255

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Progress towards Python 3.11 support #255

merged 3 commits into from
Oct 5, 2023

Conversation

cmnrd
Copy link
Contributor

@cmnrd cmnrd commented Jul 26, 2023

This PR contains @edwardalee's accompanying changes for lf-lang/lingua-franca#1902. There wasn't a PR in reactor-c yet, so I thought I just open one.

Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhstrh
Copy link
Member

lhstrh commented Oct 2, 2023

Are the changes compatible with Python 3.10? Or are we just upgrading the requirement to 3.11?

@edwardalee
Copy link
Contributor

These changes seem to work with both python 3.10 and 3.11. With python 3.11, we get a deprecation warning that should be easy to fix:

pythontarget.c:600:9: warning: 'Py_SetPath' is deprecated [-Wdeprecated-declarations]
        Py_SetPath(wcwd);

I think the tests are running with python 3.10, so it seems these changes work with 3.10. There is a companion PR in lingua-franca that is needed to actually run with python 3.11.

@edwardalee edwardalee merged commit 76d1562 into main Oct 5, 2023
@edwardalee edwardalee deleted the python-11 branch October 5, 2023 11:41
@lhstrh lhstrh changed the title Python 3.11 support Progress towards Python 3.11 support Nov 22, 2023
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants