Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting all examples and combine experimental directories #50

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

petervdonovan
Copy link
Contributor

@petervdonovan petervdonovan commented Jun 20, 2023

Fixes #36
Fixes #35

This is also a partial fix for lf-lang/lingua-franca#1847, but not a complete one because we also need to repair the tests.

This is basically a clone of #48.

I am creating this as a separate PR because the version of the formatter applied in #48 had problems that made some of its output unusable. The PR is based on applying the repaired version of the formatter that is in PR lf-lang/lingua-franca#1851. If the changes in this PR are good, then we should also merge lf-lang/lingua-franca#1851.

@lhstrh
Copy link
Member

lhstrh commented Jun 20, 2023

This looks good to me... Let's merge lf-lang/lingua-franca#1851 first and re-run CI so that the formatting checks can pass...

Copy link
Contributor

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, let's merge this :)

@cmnrd cmnrd merged commit 0bdd1f1 into main Jun 21, 2023
@cmnrd cmnrd deleted the formatting2 branch June 21, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move all experimental examples to top-level experimental directory format all examples
3 participants