Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for null reactor to avoid NPE #998

Merged
merged 2 commits into from
Mar 5, 2022
Merged

Check for null reactor to avoid NPE #998

merged 2 commits into from
Mar 5, 2022

Conversation

edwardalee
Copy link
Collaborator

This seems to fix the second problem in #994.

@edwardalee edwardalee mentioned this pull request Mar 3, 2022
Closed
@cmnrd cmnrd linked an issue Mar 4, 2022 that may be closed by this pull request
Error reporting in Epoch is broken #994
Closed
@cmnrd
Copy link
Collaborator

cmnrd commented Mar 4, 2022

I pushed a change that should fix #994 for good.

@edwardalee edwardalee merged commit 94e282b into master Mar 5, 2022
@edwardalee edwardalee deleted the npe-on-bad-reactor branch March 5, 2022 01:32
@lhstrh lhstrh mentioned this pull request Mar 17, 2022
Closed
@lhstrh lhstrh added the bug Something isn't working label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error reporting in Epoch is broken
3 participants
@edwardalee @cmnrd @lhstrh