Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eclipse error reporting #995

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Fix eclipse error reporting #995

merged 3 commits into from
Mar 3, 2022

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Mar 3, 2022

This change reverts a small part of #978 in order to fix the broken error reporting in Epoch.

Closes #994

@cmnrd
Fix eclipse error reporting
3a1ca2e 
This change reverts a small part of #978 in order to fix the broken error
reporting in Epoch.

closes #994
@cmnrd cmnrd added this to the 0.1.0 milestone Mar 3, 2022
@cmnrd cmnrd requested review from edwardalee and lhstrh March 3, 2022 09:56
edwardalee
edwardalee approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for fixing.

org.lflang/src/org/lflang/util/FileUtil.java Outdated Show resolved Hide resolved
@cmnrd @edwardalee
Fix typo
300773b 
Co-authored-by: Edward A. Lee <eal@eecs.berkeley.edu>
@cmnrd cmnrd merged commit dd0ca66 into master Mar 3, 2022
@cmnrd cmnrd deleted the fix-eclipse-error-reporting branch March 3, 2022 16:01
@lhstrh lhstrh mentioned this pull request Mar 17, 2022
Closed
@lhstrh lhstrh added the bug Something isn't working label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

@lhstrh lhstrh Awaiting requested review from lhstrh

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Error reporting in Epoch is broken
3 participants
@cmnrd @edwardalee @lhstrh