Improve warning message for unrecognized target parameters #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this is printed: ``` Unrecognized target parameter: ros. Recognized parameters are: BUILD, BUILD_TYPE, CLOCK_SYNC, CLOCK_SYNC_OPTIONS, CMAKE_INCLUDE, CMAKE, COMPILER, DOCKER, EXTERNAL_RUNTIME_PATH, FAST, FILES, FLAGS, COORDINATION, COORDINATION_OPTIONS, KEEPALIVE, LOGGING, NO_COMPILE, NO_RUNTIME_VALIDATION, PROTOBUFS, ROS2, RUNTIME_VERSION, SINGLE_FILE_PROJECT, THREADS, TIMEOUT, TRACING, EXPORT_DEPENDENCY_GAPH, EXPORT_TO_YAML, RUST_INCLUDE, CARGO_FEATURES, CARGO_DEPENDENCIES. ``` With this change, the actual parameter names are printed in alphabetical order: ``` Unrecognized target parameter: ros. Recognized parameters are: build build-type cargo-dependencies cargo-features clock-sync clock-sync-options cmake cmake-include compiler coordination coordination-options docker export-dependency-graph export-to-yaml external-runtime-path fast files flags keepalive logging no-compile no-runtime-validation protobufs ros2 runtime-version rust-include single-file-project threads timeout tracing ```
edwardalee
approved these changes
Feb 14, 2022
lhstrh
reviewed
Feb 14, 2022
Co-authored-by: Marten Lohstroh <marten@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this is printed if a target parameter is not recognized:
With this change, the actual parameter names are printed in alphabetical order: