Make the TypeScript target work on Windows #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only fully general way that I have found to check if something is executable is to try to start the process and see if an `IOException` occurs. `File.canExecute()` is insufficient -- it can return `true` when the answer is really `false`. Furthermore, successful termination of the `where` command on Windows apparently does not guarantee that the right executable will be used.
c90aa7a to
dda4413
Compare
dda4413 to
f84578e
Compare
This cache step may not be effective because the lock files that it attempts to hash do not exist when the hash is computed at the beginning of the workflow.
ffade89 to
6e2e706
Compare
lhstrh
approved these changes
Jan 18, 2022
Co-authored-by: Marten Lohstroh <marten@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that TypeScript integration tests pass on Windows.