Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python federated #675

Merged
merged 33 commits into from
Nov 7, 2021
Merged

Python federated #675

merged 33 commits into from
Nov 7, 2021

Conversation

Soroosh129
Copy link
Contributor

@Soroosh129 Soroosh129 commented Oct 26, 2021

This adds support for local federated programs written using the Python target. The data exchanged between federates is transparently serialized and deserialized using Python's pickle module.

It also adds a simple HelloDistributed.lf test.

@Soroosh129 Soroosh129 marked this pull request as ready for review October 29, 2021 06:46
@housengw housengw linked an issue Oct 31, 2021 that may be closed by this pull request
@Soroosh129
Copy link
Contributor Author

Soroosh129 commented Nov 4, 2021

I think this is ready to be merged. There are a few failing federated tests but fixing them requires augmenting the Python API to add a few missing functionalities. These changes can be put in their own PR to avoid making this PR larger than it already is. I suggest we could ignore the tests in the failing folder for now during the review process.

Thanks @housengw for meticulously porting all the federated C tests to Python. I am optimistic we can get them all to pass.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should we first merge #713?

@Soroosh129
Copy link
Contributor Author

Looks good! Should we first merge #713?

I think the order doesn't matter (hopefully). If we merge this in first, we can change the base of #713 to master.

@lhstrh lhstrh changed the base branch from master to disable-chain-id November 6, 2021 20:23
@lhstrh lhstrh changed the base branch from disable-chain-id to master November 6, 2021 20:23
@lhstrh lhstrh merged commit 8fcd6fc into master Nov 7, 2021
@lhstrh lhstrh deleted the python-federated branch November 7, 2021 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python federated execution sometimes segfaults
3 participants