Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support for the C target #532

Merged
merged 120 commits into from
Oct 6, 2021
Merged

Windows support for the C target #532

merged 120 commits into from
Oct 6, 2021

Conversation

Soroosh129
Copy link
Contributor

@Soroosh129 Soroosh129 commented Sep 23, 2021 •
edited
Loading

This is an ongoing work-in-progress to enable native Windows support in our C target.

There are three main tasks remaining:

  • Ensure that all tests pass for Linux and MacOS (currently, some are broken)
  • Enable Windows tests for the C target on GitHub Actions, and make sure that all pass (some tests should be excluded, see below)
  • Exclude federated and serialization tests (i.e., Protobuf-based tests) for Windows in our testing framework (org.lflang.tests)

Fixes #531.

The following tests are skipped on Windows:

C

  • Federated
  • AsFederated (run every test as federated)
  • Serialization
  • Target (target-specific tests, like ones with no CMake)
  • CCpp (run everything as CCpp)

Python

  • Federated
  • AsFederated
  • Serialization

@Soroosh129
Updated core file paths to user '/' since they will be copied from cl…
5af79fa 
…ass path
@Soroosh129
Renamed handle_t to trigger_handle_t to prevent naming collision with…
1e15285 
… Windows libraries
@Soroosh129
Fixed compile errors on Windows. Still getting runtime exception
b01e686
@Soroosh129
Attempt to fix compile error for Unix-based systems that was introduc…
6d28fa7 
…ed by Windows-specific changes
@Soroosh129
Resolved segmentation fault. Tracing doesn't work.
c2f37ea
@Soroosh129
Added new line to printf
c8c26f6
@Soroosh129
Updated timing functions. Changed __ prefixes to _lf_.
c73e2b5
@Soroosh129
Adjusted timing functions. Bug fixes and code format corrections.
c76f05e
@Soroosh129
Updated Python runtime to match the API name change
7f24db4
@Soroosh129
Updated test to report time per reaction
6cd71f2
@Soroosh129
Minor fixes
d26ac36
@Soroosh129
Add Windows test for the Python target
734b491
@Soroosh129
Trying protobuf on Windows again
4f1261f
@Soroosh129
Removed stray SIGPIPE
d4e2053
@Soroosh129
Updated Python target to use lf_reserved_prefix
13addb0
@Soroosh129
More usage of _lf_
ce565c9
@Soroosh129
Added lf_reserved_prefix for federated execution
a626423
@Soroosh129
Tabs to spaces
94105f8
@Soroosh129
Merge remote-tracking branch 'origin/master' into windows-c-target
5d9463d
@Soroosh129 Soroosh129 self-assigned this Sep 23, 2021
@Soroosh129 Soroosh129 added this to the 0.1.0 RC1 milestone Sep 23, 2021
@Soroosh129 Soroosh129 added c Related to C target enhancement Enhancement of existing feature help wanted Extra attention is needed labels Sep 23, 2021
@Soroosh129 Soroosh129 changed the title Windows c target Windows support for the C target Sep 24, 2021
@Soroosh129
Copy link
Contributor Author

Thanks @petervdonovan for testing this out. The issue seems to be that the ReflexGame.lf example was using pthread functions. I've now pushed a change that uses lf_thread functions. I will look for other examples and update them as I find them.

edwardalee
edwardalee approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a tour-de-force!! Let's merge it ASAP! Note very minor suggestions.

org.lflang/src/org/lflang/generator/c/CCompiler.java Outdated Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/CGenerator.xtend Outdated Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/CGenerator.xtend Outdated Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/CGenerator.xtend Outdated Show resolved Hide resolved
Soroosh129 and others added 2 commits October 5, 2021 16:37
lhstrh
lhstrh approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and ready to merge, @Soroosh129! Only left some minor comments.

@lhstrh lhstrh mentioned this pull request Oct 5, 2021
Closed
@lhstrh lhstrh merged commit 22b1bb0 into master Oct 6, 2021
@lhstrh lhstrh deleted the windows-c-target branch October 6, 2021 00:01
@Soroosh129 Soroosh129 mentioned this pull request Oct 6, 2021
Open
7 tasks
@Soroosh129 Soroosh129 mentioned this pull request Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@edwardalee edwardalee edwardalee approved these changes

Assignees

@Soroosh129 Soroosh129

Labels
c Related to C target enhancement Enhancement of existing feature help wanted Extra attention is needed python Related to the Python target
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

handle_t: Windows-specific name collision
5 participants
@Soroosh129 @cmnrd @lhstrh @petervdonovan @edwardalee