Initial Rust support #488
Merged
Initial Rust support #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intellij-rust doesn't like it and it's not really necessary Also update runtime crate name to reactor_rt
Now we use an ssh connection to access the github repo. Be aware that you need a credentials helper for this to work as the repo is private and cargo will not prompt for a password. rust-lang/cargo#1851
Tests pass \o/
Model supports nested instantiations now, but parameter handling is still todo
TODO is declaring connections somehow. But we should at least support calling startup reactions
For now, connections are not supported. But we already have logic to trigger startup recursively
This way you don't have to push and delete your lock files to use a change in the rt library
PortComposition test runs fine
Soroosh129
reviewed
Oct 16, 2021
Soroosh129
reviewed
Oct 16, 2021
Soroosh129
reviewed
Oct 16, 2021
Soroosh129
reviewed
Oct 16, 2021
lhstrh
reviewed
Oct 17, 2021
3 tasks
Extracted from fwd branch
|
@lhstrh I've tried to improve the comment situation. I'd also like to split RustEmitter into several classes to improve code quality, however, I can't do this in this PR as it would cause too many conflicts with my follow up branch. |
|
Perhaps you could factor the discussion about |
oowekyala
added a commit
that referenced
this pull request
Oct 18, 2021
Tests are still failing on windows
oowekyala
added a commit
that referenced
this pull request
Oct 19, 2021
This reverts commit a82240f.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this initial version of the rust target supports is described in this file. Most things work for simple examples, but there are still some problems that should be fixed in the runtime. That checklist is also WIP and I'll expand it to make each bullet point covered by a test case
Note: when checking out the branch for the first time, you might have to run
git submodule update --initto clone the rust runtime submodule.This is a draft until
[ ] Add gradle task to run a single test from command line #555 is mergedTODOs
Note that some changes conflict with #535. Whatever the actual order of merges I'll follow up to fix the conflicts.