-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake for the C target #402
Conversation
…is not installed on GitHub Actions
…ted on remote machines
I believe this branch is ready to merge. I have changed the default build system to be CMake and added CMake to REQUIREMENTS.md. Is there any other documentation that needs to be modified? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress toward a more modular code base! I left a few minor comments...
Co-authored-by: Marten Lohstroh <marten@berkeley.edu>
The example given in Writing-Reactors-in-C assumes cmake is not being used. I think this needs to be updated. |
Okay, thank you for pointing that out. I have added the CMake-related target parameters to the text. For now, it includes a mention to the variable |
How about we create an issue for this and just continue with the merge? |
Okay sounds good. I have created #429. |
This branch adds the option of compiling generated C target code using
cmake
. This can be enabled by using thecmake: true
target property.This branch is built on top of the
standalone-RTI
branch, which should be merged before this.