Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone rti #395

Merged
merged 24 commits into from
Jul 13, 2021
Merged

Standalone rti #395

merged 24 commits into from
Jul 13, 2021

Conversation

Soroosh129
Copy link
Contributor

This branch implements a standalone RTI that can be installed universally on a UNIX-based system.

The code for the RTI is located in the org.lflang/src/lib/core/federated/RTI folder. Perhaps, higher level directory (e.g., util) can be a better home for the RTI code.

Soroosh129 added 20 commits July 2, 2021 21:49
@Soroosh129
Use fileConfig.compilerMode
7b34ddf
@Soroosh129
Moved federated files into their own folder
9c36a64
@Soroosh129
Moved RTI-related global fields to a RTI_instance_t
5c43a15
@Soroosh129
Updated usage. Made instance definitions local
d518668
@Soroosh129
First working version of standalone RTI. Tests will fail because RTI …
ca0a631 
…is not installed on GitHub Actions
@Soroosh129
Adjusted RTI arguments
bc18580
@Soroosh129
Updated the README file with instructions on how to enable DEBUG mess…
66da5d4 
…ages
@Soroosh129
Updated CMakeLists.txt with support of enabling DEBUG messages for th…
bd492dd 
…e RTI
@Soroosh129
Fixed an issue with clock sync levels
a791bda
@Soroosh129
Updated comment to reflect how clock sync period is given to the RTI now
3938227
@Soroosh129
Fixed incorrect time value
79c4cea
@Soroosh129
First attempt at installing the RTI on Github Actions
57a8ca8
@Soroosh129
Second attempt at installing the RTI on Github Actions
6c893e8
@Soroosh129
Updated federated launcher to use the latest package format
ffb15fb
@Soroosh129
Fixed an issue where the log directory for the RTI was not being crea…
ed34e23 
…ted on remote machines
@Soroosh129
Fixed time format
e8840c7
@Soroosh129
Updates to comments and minor fix for RTI's launch command
cb0a162
@Soroosh129
Fix for type conversions
ffd610b
@Soroosh129
Enable debug messages for the RTI to see more information
39e9b48
@Soroosh129
Disable debug
d03fc04
@Soroosh129 Soroosh129 requested review from edwardalee and lhstrh July 6, 2021 06:18
edwardalee
edwardalee approved these changes Jul 6, 2021
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Go for the merge...

org.lflang/src/lib/core/federated/net_common.h Outdated Show resolved Hide resolved
lhstrh
lhstrh approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really cleans things up nicely. Great job!

org.lflang/src/lib/core/federated/net_common.h Outdated Show resolved Hide resolved
@lhstrh lhstrh merged commit dbc10b2 into master Jul 13, 2021
@lhstrh lhstrh deleted the standalone-RTI branch July 13, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Soroosh129 @edwardalee @lhstrh