Enable Branch Selection in Oomph Setup #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables testing fresh oomph installations with a specific branch.
This variable should not be available to the user since it has no effect on the actual eclipse version in the target platform.
|
Very cool! Is a default value for the variable provided, or does the user just have to write |
|
Yes, the field is prepopulated with the default value. |
|
OK, perfect!
On Thu, Jul 1, 2021 at 9:33 AM Alexander SR ***@***.***> wrote:
No, the field is prepopulated with the default value.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#388 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYD47APVRAMCGKWTHTP663TVSKDZANCNFSM47U62JXA>
.
--
…--
Marten Lohstroh | Postdoctoral Researcher
University of California | 545Q Cory Hall
Berkeley, CA 94720 | +1 510 282 9135
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow the user to specify the branch (via Lingua Franca Branch (git clone)) that will be checked out at the initial clone of the repository during installation.
It has the downside that everyone who already has an existing installation, will be prompted (once) for a value for this new user variable but I think this is acceptable.
This tackles Problem 2 in #383
As soon as this PR is merged I will adjust the screen shot in the oomph setup tutorial.
The second commit regarding the target platform variable is unrelated to the main problem.