Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savina benchmarks for Cpp and benchmark runner. #243

Merged
merged 27 commits into from
Dec 11, 2020

Conversation

hnnskl
Copy link
Contributor

@hnnskl hnnskl commented Dec 7, 2020

Overview:

  • I added implementations of Savina benchmarks for the C++ target in benchmark/Cpp/Savina.
  • For the benchmarks I used subdirectories with the same names as in the original Savina repository https://github.com/shamsimam/savina
  • I deleted the old benchmarks in that folder that are the same or a similar implementation. The other benchmarks were moved into the subdirectories, these are only different versions of the dining philosophers.
  • Benchmarks files with the name suffix "Generator" in their name contain code for the code generator Cog in comments. They can be used as normal LF files but are also parametrized.
  • The general design of the benchmarks, their output and control through the BenchmarkRunner.lf is all based on the original Savina implementations.
  • An extensible benchmark runner to automatically run the benchmarks and create graphs from the results can be found in util/BenchmarkRunner. A Readme explains how to setup and use it.

Let me know if you want any modifications.

hnnskl added 27 commits October 15, 2020 02:27
@cmnrd
Copy link
Collaborator

cmnrd commented Dec 11, 2020

Thanks @hnnskl! 👍

Should we merge this in? I am happy with it. I will probably make some adjustments to the benchmark runner in the future though.

@lhstrh
Copy link
Member

lhstrh commented Dec 11, 2020

I agree with you, @cmnrd; we should merge this into master. Great work, @hnnskl! This is a real leap forward.

I was thinking that it might be useful to discuss the workings of BenchmarkRunner during a code review session.

@lhstrh lhstrh merged commit 9dbeba1 into lf-lang:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants