Diagram support for watchdogs #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soerendomroes
requested changes
Jul 9, 2024
There was a problem hiding this comment.
Despite the minor request below, this looks like a good addition. I also tag @a-sr here (even though he does not have time) since he actually knows the diagram synthesis.
If the visualization looks pleasing and does what it is supposed to do, I would like to see this merged.
core/src/main/java/org/lflang/diagram/synthesis/LinguaFrancaSynthesis.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/lflang/diagram/synthesis/styles/LinguaFrancaShapeExtensions.java
Show resolved
Hide resolved
soerendomroes
approved these changes
Jul 11, 2024
lhstrh
reviewed
Jul 11, 2024
lhstrh
reviewed
Jul 11, 2024
|
The watchdog seems to be missing here to be able to get its attributes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds diagram support for watchdogs. They are shown as squares with a "W".