Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform name changed from Nrf52 to nRF52 #2350

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Platform name changed from Nrf52 to nRF52 #2350

merged 1 commit into from
Jul 3, 2024

Conversation

edwardalee
Copy link
Collaborator

@edwardalee edwardalee commented Jul 2, 2024 •
edited
Loading

This PR changes the capitalization of nRF52 to match what is used for CMake in reactor-c and what is the standard capitalization for this device.

@edwardalee edwardalee added the enhancement Enhancement of existing feature label Jul 2, 2024
@edwardalee edwardalee requested a review from lhstrh July 2, 2024 17:23
@lhstrh lhstrh changed the title Nrf52 support Platform name changed from Nrf52 to nRF52 Jul 2, 2024
lhstrh
lhstrh requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be rebased. There's only a one-line change in this PR and yet there are 6 commits.

@lhstrh lhstrh added refactoring Code quality enhancement and removed enhancement Enhancement of existing feature labels Jul 2, 2024
@lhstrh lhstrh enabled auto-merge July 3, 2024 10:57
@lhstrh lhstrh added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit 4c3e177 Jul 3, 2024
26 checks passed
@lhstrh lhstrh deleted the nrf52 branch July 3, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
refactoring Code quality enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardalee @lhstrh