Fix for edge case in which comments are dropped #1924
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vscode-lingua-franca/133.
In the issue, the comment
// test
would be completely erased from the following program by the formatter:This fixes that issue such that the program is instead formatted like this:
I realize that some people might expect the comment to remain inside the reactor, but I think that that would be too much work to implement without much obvious benefit. With the current design, the comment must be associated with some AST node in order to not be dropped; in this case, it is associated with the whole reactor (no other alternatives are available), and as a result, it goes above the reactor.